fix(terraform_plan): plan connection detection with unresolved refs #7301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added PlanConnectionResolver to infer connections when plan values are unresolved - Enhanced DeepAnalysisGraphManager to use the resolver for plan files - Handles cases where target_resource_id and similar attributes are unknown at plan time - Infers connections based on module structure and resource types - Added comprehensive tests for the new functionality This fixes connection-type external checks that fail on terraform plan files when resource references are only resolved during terraform apply. Fixes issue with Azure Monitor Diagnostic Settings connections to resources like Redis Cache when using for_each loops with dynamic references.
omriyoffe-panw
had a problem deploying
to
scan-security
GitHub Actions
Failure
- Removed all redundant inference methods (400+ lines) - Now relies solely on PlanConnectionResolver for unresolved connections - Changed verbose INFO logging to DEBUG level - Simplified from 481 lines to 87 lines (82% reduction) The fix still works correctly as verified by tests. This refactoring: - Eliminates maintenance burden of duplicate systems - Improves performance by avoiding recursive attribute scanning - Makes the code cleaner and more maintainable - Keeps the same functionality with much less complexity
omriyoffe-panw
had a problem deploying
to
scan-security
GitHub Actions
Failure
omriyoffe-panw
had a problem deploying
to
scan-security
GitHub Actions
Failure
omriyoffe-panw
had a problem deploying
to
scan-security
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: