fix(terraform): Handled git external module loading with sub-directory but without protocol #7272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectory with no protocol
bo156
commented
Aug 11, 2025
| headers: dict[str, Any], | ||
| payload: dict[str, Any] | None = None, | ||
| ) -> ClientResponse: | ||
| from checkov.common.util import env_vars_config |
There was a problem hiding this comment.
this import moved due to an import loop of env_var_config and http_utils
yuvalmich
approved these changes
Aug 12, 2025
| if len(module_source_components) < 3: | ||
| root_module = module_source_components[-1] | ||
| inner_module = "" | ||
| if len(module_source_components) == 2 and "git::git" in module_source_components[0]: |
There was a problem hiding this comment.
I think it would be helpful if we had a comment here (and in other places in this method) which would explain which use case it solves.
i.e. in this case if I got it right it would be
// git::git@github.com:test-inner-module/out-module//inner-module?ref=main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Handled git external module loading with sub-directory but without protocol, specifically when using
git::gitrather thangit::https://...(or any other protocol instead of https).This makes sure we correctly parse the sub-directory inside the source url.
Checklist: