fix(graph): fix attributes checks logic #7264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
changed the title
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
bo156
requested changes
Jul 31, 2025
| return False | ||
| return None if has_unrendered_attribute else True | ||
| if not found: | ||
| return "not found" |
There was a problem hiding this comment.
this should be extracted to a const
| return reduce(and_, args) | ||
|
|
||
| def get_operation(self, vertex: Dict[str, Any]) -> Optional[bool]: | ||
| def get_operation(self, vertex: Dict[str, Any]) -> Union[Optional[bool], str]: |
There was a problem hiding this comment.
I don't like that the return type changed like that, specifically if we want to return not found we should use Literal["not found"] to be more specific.
In addition - is it really needed? Can't we just return the value which will not change the check?
For example in and-solver we can return True and in or-solver return False, to make sure this is simpler
There was a problem hiding this comment.
this was my last resort, it's essential because otherwise it affects checks results, which is not what we want.
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
inbalavital
had a problem deploying
to
scan-security
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the logic of the "and" and "or" condition solvers to correctly handle cases where required resource_types are not present in the evaluated tf file.
Previously, if a policy condition referenced a resource type that did not exist in the code under test, the evaluation would incorrectly result in a failed check. This behavior has now been fixed:
Conditions that reference missing resource types now return a special "not found" value.
The solvers treat "not found" as non-applicable, and the overall check ignores that return value.