fix(terraform): correctly evaluate CKV_AWS_37 when there's a dynamic … #6792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Waring
temporarily deployed
to
scan-security
GitHub Actions
Inactive
|
@Saarett I see you were active on my other PR, this one is ready for review if you have time please |
tsmithv11
had a problem deploying
to
scan-security
GitHub Actions
Failure
|
@Alex-Waring looks good, but can you fixe the flake8 errors? |
|
Hey @Alex-Waring, |
Alex-Waring
had a problem deploying
to
scan-security
GitHub Actions
Failure
Alex-Waring
force-pushed
the
AWar/eks_control_plane_logging/bug
branch
from
6883990 to
1f88271
Compare
Alex-Waring
had a problem deploying
to
scan-security
GitHub Actions
Failure
|
@MaryArmaly can you please re-run the CI? |
tjwald
reviewed
Sep 29, 2025
checkov/terraform/checks/resource/aws/EKSControlPlaneLogging.py
Outdated
Show resolved
Hide resolved
tjwald
reviewed
Sep 29, 2025
checkov/terraform/checks/resource/aws/EKSControlPlaneLogging.py
Outdated
Show resolved
Hide resolved
|
Hi @tjwald, I no longer have the repo setup for local development here given the time it took for a review. If this is something you are interested in adding to the project then please feel free to commit to this pr. |
tjwald
requested a deployment
to
scan-security
GitHub Actions
Waiting
fix linting and access pattern
tjwald
temporarily deployed
to
scan-security
GitHub Actions
Inactive
TsilaHadad
approved these changes
Sep 30, 2025
TsilaHadad
reviewed
Sep 30, 2025
Saarett
approved these changes
Sep 30, 2025
achiar99
approved these changes
Sep 30, 2025
Saarett
pushed a commit
that referenced
this pull request
Sep 30, 2025
#6792) * fix(terraform): correctly evaluate CKV_AWS_37 when there's a dynamic block * Update EKSControlPlaneLogging.py fix linting and access pattern --------- Co-authored-by: Tj <52830708+tjwald@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
…block
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
For reasons that are beyond me,
enabled_cluster_log_typesis a list of strings normally, but when there's a dynamic block added to the resource it becomes a list of list of strings. This PR adds tests to confirm that this is indeed an issue (if you run the test file against the check in master then it fails onaws_eks_cluster.fully_enabled_with_dynamic_block), and fixes the issue by checking the type before itterating.Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
EKSControlPlaneLoggingcheck to handle dynamic blocks in AWS EKS cluster resourcesModified files (1)
Latest Contributors(2)
EKSControlPlaneLoggingcheck, including Terraform configurations and Python unit testsModified files (2)
Latest Contributors(2)