-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add support for awscc provider secrets check #6647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for awscc provider secrets check #6647
Conversation
Hey @quixoticmonk, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Can you please merge main into your branch and make the suggested updates so we can run the tests?
Hey @quixoticmonk, |
Hey @quixoticmonk, I noticed this check already exists in the secrets framework (CKV_SECRET_2). |
@pazbechor I was porting over AWS provider's credential check while the CKV_SECRET_2 seems to be checking for access key/secrey key anywhere. Does it make the AWS provider one redundant too on the provider configuration ? |
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
The PR intends to extend the CKV_AWS_41 to have an AWSCC variant to the support the provider. Since the IDs have to be unique, I have currently kept it to be CKV_AWSCC_41 with the assumption that the rules are based on the provider and not the target platform. Ideally this can be handled as an extension to CKV_AWS_41, but the tests and any additional resourced based rules would need AWS CC based resources which have a different resource attribute structure in many cases.
Though this PR doesn't fix #6410, the intention is to start contributing rules targeting AWSCC provider.
New/Edited policies (Delete if not relevant)
Description
The rule maps back to the way a provider is configured to work with AWS.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Modified files (3)
Latest Contributors(0)
Modified files (3)
Latest Contributors(2)