fix skipChecks overriding config file #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'ENOENT: no such file or directory, open 'exthost'
Merged
XargsUK
reviewed
Apr 16, 2025
| @@ -77,15 +77,20 @@ export const runCheckovScan = (logger: Logger, checkovInstallation: CheckovInsta | |||
| const certificateParams: string[] = certPath && checkovInstallationMethod !== 'docker' ? ['-ca', `"${certPath}"`] : []; | |||
| const bcIdParam: string[] = useBcIds ? ['--output-bc-ids'] : []; | |||
| const noCertVerifyParam: string[] = noCertVerify ? ['--no-cert-verify'] : []; | |||
| const skipCheckParam: string[] = skipChecks.length ? ['--skip-check', skipChecks.join(',')] : []; | |||
| const skipCheckParam: string[] = skipChecks | |||
There was a problem hiding this comment.
This logic seems to always append the default skip (BC_LIC*) to the user’s skip list, and doesn't allow for an empty skip list.
Merged
|
Thanks for the contribution! I didn't have the perms to update your branch directly, so I pulled your changes into a different branch and made a couple of tweaks. I'll hopefully be getting this released today. Really appreciate the hand! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10 [Feature]: List of skipped checks (and closes bridgecrewio#125)
This disables the hardcoded
--skip-check BC_LIC*, ensuring theskip-check:from.checkov.yamlconfig file are evaluated as expected if config file defined.Also adds an extension configuration option that overwrites any checkov.yaml config, similar to frameworks of skip-frameworks.