Supports embedded images #200
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.0
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This was contributed by @lionelhorn. Approach is to wait for the "update" message that has the embedded files then create `initialData` with the files and only then render the Excalidraw component. Mobx is used for state management replacing react `useState`. Which is easier to get the code a bit cleaner code than passing the setters of `useState` to the bridge. Co-authored-by: Lionel <dev@lionelhorn.com>
Owner
Author
|
Thanks to @lionelhorn with is clever observation on Original work: lionelhorn@6fd259f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code has to both
Fixes: #199
See
Might be of help:
Doc