Document BIP353 parsing #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
approved these changes
Mar 12, 2025
snippets/dart_snippets/pubspec.lock
Outdated
Comment on lines
47
to
50
| path: "." | ||
| ref: HEAD | ||
| resolved-ref: "3111663fbc91aa918a9b44f7deadaf97f94462b9" | ||
| url: "https://github.com/breez/breez-sdk-liquid-dart" | ||
| source: git | ||
| version: "0.7.2" | ||
| path: "packages/breez-sdk-liquid-dart" | ||
| relative: true | ||
| source: path | ||
| version: "0.6.0-dev1" |
There was a problem hiding this comment.
This from local testing?
There was a problem hiding this comment.
Oops, thanks. Dropped the changes to the file in 647517a
snippets/dart_snippets/pubspec.lock
Outdated
Comment on lines
141
to
142
| path: "." | ||
| ref: HEAD | ||
| resolved-ref: "3635ca4abebd2ccd5455e1112eaa46cee10888d6" | ||
| url: "https://github.com/breez/breez-sdk-liquid-flutter" | ||
| source: git | ||
| version: "0.7.2" | ||
| path: "packages/breez-sdk-liquid-flutter" | ||
| relative: true | ||
| source: path | ||
| version: "0.6.0-dev1" |
There was a problem hiding this comment.
Fixed: 647517a
danielgranhao
force-pushed
the
daniel-document-bip353-parsing
branch
from
4769f6b to
647517a
Compare
dangeross
approved these changes
Mar 12, 2025
roeierez
approved these changes
Mar 12, 2025
dangeross
added a commit
that referenced
this pull request
Mar 13, 2025
* Add seed option to ConnectRequest * Document BIP353 parsing (#86) --------- Co-authored-by: Daniel Granhão <32176319+danielgranhao@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a brief mention to the parse documentation about BIP353 being supported. It also updates the snippets.