Skip to content

Fix Python snippet callbacks and logs #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Fix Python snippet callbacks and logs #82

merged 1 commit into from
Mar 7, 2025

Conversation

danielgranhao
Copy link
Contributor

This PR addresses 2 issues with the Python snippets:

  • adds a missing self parameter to the Python snippet callbacks
  • Uses f-strings for logging where they weren't yet used. Comma-separated values don't work because logging methods behave differently from print().

dangeross
dangeross approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangeross
Copy link
Contributor

Seems some dependencies in rust are downgraded, not sure if its relevant

@danielgranhao danielgranhao force-pushed the daniel-fix-python-logging-snippet branch from 8128c8f to e34cd54 Compare February 26, 2025 22:33
@danielgranhao
Copy link
Contributor Author

Seems some dependencies in rust are downgraded, not sure if its relevant

Dropped those changes. Thanks

@danielgranhao danielgranhao merged commit 1a0a00c into main Mar 7, 2025
74 checks passed
@danielgranhao danielgranhao deleted the daniel-fix-python-logging-snippet branch March 7, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangeross dangeross dangeross approved these changes

@erdemyerebasmaz erdemyerebasmaz erdemyerebasmaz approved these changes

@roeierez roeierez Awaiting requested review from roeierez

@hydra-yse hydra-yse Awaiting requested review from hydra-yse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielgranhao @dangeross @erdemyerebasmaz