Skip to content

Conversation

@onyb
Copy link
Member

@onyb onyb commented Sep 14, 2025

This refactoring has two goals:

  1. Introduce chain IDs for non-EVM and Solana chains, such as Bitcoin, ZCash, Filecoin, etc. This follows the convention we follow in brave-core.
  2. Centralise all chain-specific information, such as Simplehash ID, Alchemy ID, etc., within the same enum. This avoids the need to maintain mappings like ChainIdCoinTypeMap, AlchemyChain, SimpleHashChain, etc.

Consequently, the ChainId enum has been removed.

This PR also fixes a unit test which was making real calls to the Coingecko API.

@onyb onyb requested a review from Douglashdaniel September 14, 2025 16:24
@onyb onyb self-assigned this Sep 14, 2025
@onyb onyb force-pushed the chain-refactoring branch from 0ef98f0 to 131f9d3 Compare September 14, 2025 16:52
@onyb onyb enabled auto-merge (squash) September 14, 2025 16:57
@onyb onyb disabled auto-merge September 15, 2025 12:35
@onyb onyb enabled auto-merge (squash) September 15, 2025 12:56
@onyb onyb merged commit 6e95fc1 into master Sep 15, 2025
5 checks passed
@onyb onyb deleted the chain-refactoring branch September 15, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants