Switch to freeqdsk for reading/writing geqdsk files #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FreeQDSK doesn't like some of the test files, so I've fixed it there -- just waiting for that to be reviewed and merged, so I can make a new release and bump the version here |
ZedThree
force-pushed
the
use-freegs
branch
from
53c48f4 to
dbc79ed
Compare
|
This is failing on Python 3.8 because FreeQDSK requires Python 3.9 (see #185) |
johnomotani
approved these changes
Aug 21, 2025
There was a problem hiding this comment.
Thanks @ZedThree!
Fingers crossed, tests should be fixed once we merge master, which will get rid of the Python-3.8 tests.
|
Maybe update/merge this once #180 is approved/merged? |
This was referenced Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179
doc/whats-new.mdwith a summary of the changesAnnoyingly, one of the tests changes by 1e-9, the limit of tolerance