snes solver: Consider timestep change at output #3180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the timestep adjustment was inside a conditional
`if (looping) {...`. The variable `looping` is false when the
simulation time reaches or exceeds the next output time.
This meant that when the internal timestep exceeded the output
step, `looping` was almost always `false` and so the internal
timestep would saturate.
With this change a timestep adjustment will be considered after
every successful internal timestep.
Note: There may have been a reason why timestep adjustments were
not considered, but I can't remember what it was and it was not
documented.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZedThree
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the timestep adjustment was inside a conditional
if (looping) {.... The variableloopingis false when the simulation time reaches or exceeds the next output time.This meant that when the internal timestep exceeded the output step,
loopingwas almost alwaysfalseand so the internal timestep would saturate.With this change a timestep adjustment will be considered after every successful internal timestep.
Note: There may have been a reason why timestep adjustments were not considered, but I can't remember what it was and it was not documented.
It looks like lots of changes but it's really only 2 or 3 lines. Mostly whitespace changes.