Skip to content

Conversation

@tomc271
Copy link
Collaborator

@tomc271 tomc271 commented Sep 17, 2025

Fixes the test failures in issue #2980.

@tomc271 tomc271 requested a review from ZedThree September 17, 2025 14:01
@tomc271 tomc271 added the bugfix label Sep 17, 2025
dschwoerer
dschwoerer previously approved these changes Sep 18, 2025
Copy link
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Do we need a CI on freeBSD to prevent regressions?

Output always goes to stdout when no error.
@ZedThree
Copy link
Member

Do we need a CI on freeBSD to prevent regressions?

I think it's a fairly low use case, so it's not worth the effort.

@tomc271 tomc271 marked this pull request as ready for review September 19, 2025 11:01
@ZedThree ZedThree merged commit d9db6ef into next Oct 1, 2025
28 checks passed
@ZedThree ZedThree deleted the fixes-for-freebsd branch October 1, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants