Skip to content

Conversation

@marco-langer
Copy link
Contributor

Description

This PR replaces Gil's gil::detail::copy_n with std::copy_n.

Tasklist

  • Ensure all CI builds pass
  • Review and approve

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.27%. Comparing base (151fd9c) to head (46497d0).
⚠️ Report is 96 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #686      +/-   ##
===========================================
- Coverage    80.32%   80.27%   -0.06%     
===========================================
  Files          117      117              
  Lines         5032     5019      -13     
===========================================
- Hits          4042     4029      -13     
  Misses         990      990              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

diff_t l=dst.width()-dst.x_pos();
diff_t numToCopy=(n<l ? n : l);
detail::copy_n(src.x(), numToCopy, dst.x());
std::copy_n(src.x(), numToCopy, dst.x());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added line #L244 was not covered by tests

Hmm, this one is interesting. I'd have expected those to be fully covered.

Copy link
Contributor Author

@marco-langer marco-langer Jun 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any test cases for core\algorithm\copy_pixels. The other specializations of struct copier_n are apparently triggered by some unrelated test cases from extension or image processing tests AFAIS.

Edit: this is not true, there are some legacy tests, which do not cover this case. However, the Jamfile in test\legacy says these tests should not be refactored or extended. Thus, should we rather add new copy_pixels tests in core\algorithm\copy_pixels.cpp?

@mloskot mloskot added cat/refactoring Any nonfunctional changes core boost/gil ext/image_processing boost/gil/extension/image_processing labels Jun 28, 2022
@mloskot mloskot added this to the Boost 1.81+ milestone Jul 7, 2022
@mloskot mloskot modified the milestones: Boost 1.82, Boost 1.83+ Mar 31, 2023
@mloskot mloskot modified the milestones: Boost 1.86, 1.87.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat/refactoring Any nonfunctional changes core boost/gil ext/image_processing boost/gil/extension/image_processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants