refactor: replaces picocolors with node:util's styleText
#346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1569bc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dreyfus92
changed the title
picocolors with node:util's styleText
dreyfus92
changed the title
picocolors with node:util's styleTextpicocolors with node:util's styleText
|
@example/basic • @example/changesets commit: |
43081j
reviewed
Jun 13, 2025
| @@ -41,38 +41,41 @@ export const groupMultiselect = <Value>(opts: GroupMultiSelectOptions<Value>) => | |||
| const isLast = isItem && (next as any).group === true; | |||
| const prefix = isItem ? (selectableGroups ? `${isLast ? S_BAR_END : S_BAR} ` : ' ') : ''; | |||
| const spacingPrefix = | |||
| groupSpacing > 0 && !isItem ? `\n${color.cyan(S_BAR)} `.repeat(groupSpacing) : ''; | |||
| // groupSpacing > 0 && !isItem ? `\n${color.cyan(S_BAR)} `.repeat(groupSpacing) : ''; | |||
There was a problem hiding this comment.
is this left over? and should be removed
| ) | ||
| .join('\n'); | ||
| output.write( | ||
| `${color.gray(S_BAR)}\n${color.green(S_STEP_SUBMIT)} ${color.reset(title)} ${color.gray( | ||
| `${styleText('gray', S_BAR)}\n${styleText('green', S_STEP_SUBMIT)} ${styleText('reset', title || '')} ${styleText( |
There was a problem hiding this comment.
when is title nullish? i.e. why did we end up with ||?
| @@ -15,23 +15,25 @@ export const password = (opts: PasswordOptions) => { | |||
| input: opts.input, | |||
| output: opts.output, | |||
| render() { | |||
| const title = `${color.gray(S_BAR)}\n${symbol(this.state)} ${opts.message}\n`; | |||
| // const title = `${color.gray(S_BAR)}\n${symbol(this.state)} ${opts.message}\n`; | |||
There was a problem hiding this comment.
maybe remove this comment too?
| @@ -115,7 +115,8 @@ export const spinner = ({ | |||
| unblock = block({ output }); | |||
| _message = removeTrailingDots(msg); | |||
| _origin = performance.now(); | |||
| output.write(`${color.gray(S_BAR)}\n`); | |||
| // output.write(`${color.gray(S_BAR)}\n`); | |||
There was a problem hiding this comment.
another comment we can probably remove
| @@ -12,7 +12,7 @@ exports[`autocomplete > can be aborted by a signal 1`] = ` | |||
| [36m│[39m [2m○[22m [2mCherry[22m | |||
| [36m│[39m [2m○[22m [2mGrape[22m | |||
| [36m│[39m [2m○[22m [2mOrange[22m | |||
| [36m│[39m [2m[2m↑/↓[22m[2m to select • [2mEnter:[22m[2m confirm • [2mType:[22m[2m to search[22m | |||
| [36m│[39m [2m[2m↑/↓[22m to select • [2mEnter:[22m confirm • [2mType:[22m to search[22m | |||
There was a problem hiding this comment.
this shows that styleText doesn't handle nested colours. e.g.:
styleText(`i am dim ${styleText('bold', 'i am bold')} i am no longer dim`);we should search our code for any nested styles and double check they actually work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #338