fix: use correct solv token #694

gregdhill · 2025-07-22T12:22:58Z

Summary by CodeRabbit

Bug Fixes
- Updated the token address for Solv (xSolvBTC) to ensure accurate points incentives display.

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

vercel · 2025-07-22T12:23:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
bob-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 22, 2025 0:25am

coderabbitai · 2025-07-22T12:23:04Z

Walkthrough

The change updates the token address key for xSolvBTC in the tokensPointsIncentives map within the strategy module. The old address is replaced with a new one, while the associated incentives and all other logic remain unchanged.

Changes

File(s)	Change Summary
sdk/src/gateway/strategy.ts	Updated xSolvBTC token address key in `tokensPointsIncentives` map.

Estimated code review effort

1 (~2 minutes)

Possibly related PRs

chore(Solv): rename SolvBTC.BBN to xSolvBTC #560: Renames the token from SolvBTC.BBN to xSolvBTC and updates documentation and metadata; both PRs modify aspects of the same token.
feat(sdk): expose points and APY #558: Introduces the tokensPointsIncentives map and related data structures, which are directly modified by this PR.

Poem

A token hopped to a brand new place,
Its address changed, but kept the same face.
Incentives untouched, the map’s up to date,
For bunnies who code, that’s something to celebrate!
🐇✨

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/token-incentive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

sdk/src/gateway/strategy.ts (1)

86-117: Harden against casing errors

This is the second time an address casing slip has caused a silent failure.
Consider wrapping address keys with .toLowerCase() when constructing tokensPointsIncentives (and similar maps) or introducing a helper that normalises addresses at insertion time.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 769f6e1 and b271240.

📒 Files selected for processing (1)

sdk/src/gateway/strategy.ts (1 hunks)

coderabbitai · 2025-07-22T12:24:24Z

sdk/src/gateway/strategy.ts

        // Solv (xSolvBTC)
-        '0x0bef2a8b771e37763c1ce02a88f404c6b2573843',
+        '0xCC0966D8418d412c599A6421b760a847eB169A8c',
        [solvPoints, babylonPoints],
    ],


🛠️ Refactor suggestion

⚠️ Potential issue

Mixed-case key breaks lookup

getTokensIncentives() lower-cases the incoming token address (line 191).
Because this new map key is mixed-case, the lookup will fail and xSolvBTC will no longer receive its incentives.

- '0xCC0966D8418d412c599A6421b760a847eB169A8c', + '0xcc0966d8418d412c599a6421b760a847eb169a8c',

Make all keys lowercase (or normalise on insertion) to keep behaviour consistent.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

// Solv (xSolvBTC)

'0x0bef2a8b771e37763c1ce02a88f404c6b2573843',

'0xCC0966D8418d412c599A6421b760a847eB169A8c',

[solvPoints, babylonPoints],

],

// Solv (xSolvBTC)

'0xcc0966d8418d412c599a6421b760a847eb169a8c',

[solvPoints, babylonPoints],

],

🤖 Prompt for AI Agents

In sdk/src/gateway/strategy.ts around lines 93 to 96, the token address key for xSolvBTC is mixed-case, but getTokensIncentives() lowercases addresses before lookup, causing a mismatch and failed incentive retrieval. Fix this by converting the token address key to lowercase when inserting it into the map to ensure consistent case normalization and successful lookups.

fix: use correct solv token

b271240

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>

coderabbitai bot reviewed Jul 22, 2025

View reviewed changes

vercel bot deployed to Preview July 22, 2025 12:25 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: use correct solv token #694

fix: use correct solv token #694

Uh oh!

gregdhill commented Jul 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 22, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Jul 22, 2025

Uh oh!

Uh oh!

fix: use correct solv token #694

Are you sure you want to change the base?

fix: use correct solv token #694

Uh oh!

Conversation

gregdhill commented Jul 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gregdhill commented Jul 22, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jul 22, 2025 •

edited

Loading

coderabbitai bot commented Jul 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)