update deps, golangci-lint version: #426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelrebel
reviewed
Oct 17, 2025
joelrebel
reviewed
Nov 7, 2025
jacobweinstock
force-pushed
the
xnet-update
branch
from
5e08233 to
12c71e4
Compare
golang.org/x/net v0.46.0 requires the bump to go 1.24.0. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
There are 2 medium vulnerabilities in golang.org/x/net that necessitate the upgrade. v0.38.0 of golang.org/x/net requires go 1.23. Also v1.38.0 of go.opentelemetry.io/otel and go.opentelemetry.io/otel/trace also require go 1.23. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Enable linters in golangci-lint config. This makes it so that linters are actually run. Update golangci-lint version to latest. Fix all issues after upgrade. Pass through exit code/status from golangci-lint. This will cause the Make target to fail with a non 0 exit. This is needed so that linting is enforced by CI. Remove golangci-lint from GitHub Actions. make all-checks handles downloading and running golangci-lint and will keep it the version up-to-date. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
xnet-update
branch
from
12c71e4 to
81c0463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
There are 2 medium vulnerabilities in
golang.org/x/netthat necessitate the upgrade.v0.38.0ofgolang.org/x/netrequiresgo 1.23. Alsov1.38.0ofgo.opentelemetry.io/otelandgo.opentelemetry.io/otel/tracerequirego 1.23. This will require all consumers to have >= Go 1.23. The current latest Go version is 1.25 and, Go 1.26 is expected to be released in February of 2026. Happy to discuss holding off on this or other alternatives if bumping the Go version is a concern.Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes