-
Notifications
You must be signed in to change notification settings - Fork 6
Add tracing-subscriber #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
0504992
to
2daf6b6
Compare
@patrickelectric what if we put use tracing::info; as optional features on common args? examples/common/mod.rs then users can optionally use as: |
CI 2 fixed, CI 1 should be OK. |
Tracing configuration is done via RUST_LOG |
I mean the usage to be optional, with default false, check current CI output. Currently it spam any newcomer user with debugging info, it even increased all tests time from 2s to timeout 30s. I'm suggesting to pass and aditional clap argument like: |
ac8edc6
to
974c5f8
Compare
@RaulTrombin fixed to use env configuration |
@RaulTrombin it appears that is an issue with the CI inner script
It's not related to this PR |
it was something on hardware, a power cycle on ping1d fixed. |
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
974c5f8
to
f66d3f5
Compare
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
f66d3f5
to
a05f303
Compare
No description provided.