Skip to content

Conversation

patrickelectric
Copy link
Member

No description provided.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@RaulTrombin
Copy link
Member

@patrickelectric what if we put

use tracing::info;
and
tracing_subscriber::fmt().init();

as optional features on common args? examples/common/mod.rs

then users can optionally use as:
cargo run --example ping_1d -- --serial-port /dev/ttyUSB0 ** --is-tracing **

@RaulTrombin
Copy link
Member

CI 2 fixed, CI 1 should be OK.

@patrickelectric
Copy link
Member Author

@patrickelectric what if we put

use tracing::info; and tracing_subscriber::fmt().init();

as optional features on common args? examples/common/mod.rs

then users can optionally use as: cargo run --example ping_1d -- --serial-port /dev/ttyUSB0 ** --is-tracing **

Tracing configuration is done via RUST_LOG

@RaulTrombin
Copy link
Member

RaulTrombin commented Apr 16, 2025

I mean the usage to be optional, with default false, check current CI output. Currently it spam any newcomer user with debugging info, it even increased all tests time from 2s to timeout 30s.

I'm suggesting to pass and aditional clap argument like:
matches.get_flag("enable-tracing") {
tracing_subscriber::fmt().init();
}
On the common module that is shared to all examples.

@patrickelectric
Copy link
Member Author

@RaulTrombin fixed to use env configuration

@patrickelectric
Copy link
Member Author

@RaulTrombin it appears that is an issue with the CI inner script

/etc/github_runner/run-tests.sh: line 17: 1744812078.382779361: syntax error: invalid arithmetic operator (error token is ".382779361")

It's not related to this PR

@RaulTrombin
Copy link
Member

@RaulTrombin it appears that is an issue with the CI inner script

/etc/github_runner/run-tests.sh: line 17: 1744812078.382779361: syntax error: invalid arithmetic operator (error token is ".382779361")

It's not related to this PR

it was something on hardware, a power cycle on ping1d fixed.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@RaulTrombin RaulTrombin merged commit c8c03a8 into bluerobotics:master Apr 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants