Skip to content

Conversation

nicoschmdt
Copy link
Contributor

@nicoschmdt nicoschmdt commented Sep 26, 2025

@joaomariolago explained that the way Kraken API works is not compatible with having an update endpoint. To avoid the problem described in this issue we should merge this PR after #3568.

Summary by Sourcery

Remove Kraken update endpoint and clean up corresponding frontend and backend logic to simplify extension updates.

Bug Fixes:

  • Eliminate incompatible Kraken update endpoint to prevent API conflicts.

Enhancements:

  • Unify extension update workflow to always use the install endpoint.

Chores:

  • Remove update_local method from ExtensionManagerView.vue.
  • Remove updateExtension function from KrakenManager.ts.
  • Delete /update route from Kraken API router.

Copy link

sourcery-ai bot commented Sep 26, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the unsupported “update” endpoint and all related frontend and backend update logic, consolidating extension lifecycle operations into a single install workflow.

Class diagram for KrakenManager after update removal

classDiagram
class KrakenManager {
  +fetchManifestSources()
  +installExtension()
  +uninstallExtension()
  +disabledManifestSource()
  +setManifestSourcesOrders()
  +setManifestSourceOrder()
  -updateExtension()  -- removed
}
class InstalledExtensionData {
  +identifier: string
  +name: string
  +docker: string
  +tag: string
  +permissions: string
  +user_permissions: string
}
KrakenManager "1" -- "*" InstalledExtensionData: manages
Loading

File-Level Changes

Change Details Files
Unified extension install workflow by removing update branches
  • Removed conditional check for editing vs. install
  • Deleted update_local invocation in submit handler
  • Always invoke install with full parameters
core/frontend/src/views/ExtensionManagerView.vue
Removed frontend update handler in KrakenManager
  • Deleted updateExtension function implementation
  • Dropped updateExtension export from default module
core/frontend/src/components/kraken/KrakenManager.ts
Dropped /extension/update API route in Kraken service
  • Removed POST /update router definition
  • Cleaned up associated controller logic
core/services/kraken/api/v2/routers/extension.py

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric
Copy link
Member

patrickelectric commented Sep 30, 2025

@nicoschmdt can you rebase the PR ?

@nicoschmdt nicoschmdt force-pushed the remove-endpoint-update-from-kraken branch from 1ad1b48 to 20b021c Compare October 2, 2025 17:21
@nicoschmdt nicoschmdt force-pushed the remove-endpoint-update-from-kraken branch from 20b021c to 2c5d250 Compare October 2, 2025 17:23
@patrickelectric patrickelectric merged commit 3add0c0 into bluerobotics:master Oct 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants