-
Notifications
You must be signed in to change notification settings - Fork 111
kraken: remove update endpoint #3569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
patrickelectric
merged 1 commit into
bluerobotics:master
from
nicoschmdt:remove-endpoint-update-from-kraken
Oct 3, 2025
Merged
kraken: remove update endpoint #3569
patrickelectric
merged 1 commit into
bluerobotics:master
from
nicoschmdt:remove-endpoint-update-from-kraken
Oct 3, 2025
+2
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the unsupported “update” endpoint and all related frontend and backend update logic, consolidating extension lifecycle operations into a single install workflow. Class diagram for KrakenManager after update removalclassDiagram
class KrakenManager {
+fetchManifestSources()
+installExtension()
+uninstallExtension()
+disabledManifestSource()
+setManifestSourcesOrders()
+setManifestSourceOrder()
-updateExtension() -- removed
}
class InstalledExtensionData {
+identifier: string
+name: string
+docker: string
+tag: string
+permissions: string
+user_permissions: string
}
KrakenManager "1" -- "*" InstalledExtensionData: manages
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
joaomariolago
approved these changes
Sep 29, 2025
patrickelectric
approved these changes
Sep 30, 2025
@nicoschmdt can you rebase the PR ? |
patrickelectric
approved these changes
Oct 1, 2025
1ad1b48
to
20b021c
Compare
20b021c
to
2c5d250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joaomariolago explained that the way Kraken API works is not compatible with having an
update
endpoint. To avoid the problem described in this issue we should merge this PR after #3568.Summary by Sourcery
Remove Kraken update endpoint and clean up corresponding frontend and backend logic to simplify extension updates.
Bug Fixes:
Enhancements:
Chores: