Skip to content

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Aug 30, 2025

The frontend timeout is 10 seconds, the backend run the tests in parallel, but since the website has a 10s window to reply, if one of the websites does not answer in time, it'll trigger connection unknown over limited.

Summary by Sourcery

Enhancements:

  • Reduce the HTTP request timeout in check_website from 10 seconds to 5 seconds

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Copy link

sourcery-ai bot commented Aug 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR tightens the timeout window for website health checks by halving the HTTP request timeout from 10 to 5 seconds in the core helper routine.

Sequence diagram for website health check with updated timeout

sequenceDiagram
    participant Helper
    participant Website
    participant WebsiteStatus
    Helper->>Website: simple_http_request(timeout=5)
    Website-->>Helper: HTTP response (within 5s or timeout)
    Helper->>WebsiteStatus: Create WebsiteStatus(online=False if timeout)
Loading

Class diagram for check_website function and related types

classDiagram
    class Helper {
        +simple_http_request(hostname, port, path, timeout, method)
    }
    class Website {
        +value: dict
    }
    class WebsiteStatus {
        +site: Website
        +online: bool
    }
    Helper --|> WebsiteStatus : creates
    WebsiteStatus o-- Website : site
Loading

File-Level Changes

Change Details Files
Reduce HTTP request timeout for check_website
  • Lower timeout argument passed to simple_http_request from 10s to 5s
core/services/helper/main.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@patrickelectric patrickelectric added the move-to-stable Needs to be cherry-picked and move to stable label Aug 30, 2025
@Williangalvani Williangalvani merged commit 04d31d3 into bluerobotics:master Aug 30, 2025
6 checks passed
@patrickelectric patrickelectric removed the move-to-stable Needs to be cherry-picked and move to stable label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants