-
Notifications
You must be signed in to change notification settings - Fork 111
Use our own index-proxy instead of dockerhub directly #3500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Williangalvani
wants to merge
2
commits into
bluerobotics:master
Choose a base branch
from
Williangalvani:change_index
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the custom DockerHub API client with calls to our internal index-proxy service for retrieving image tags and streamlines tag handling in the version chooser. Sequence diagram for fetching remote image tags via index-proxysequenceDiagram
participant chooser.py
participant aiohttp.ClientSession
participant index-proxy (logtools.cloud)
chooser.py->>aiohttp.ClientSession: Create session
chooser.py->>index-proxy (logtools.cloud): GET /GetImages?repository=...&arch=...&index=dockerhub
index-proxy (logtools.cloud)-->>chooser.py: Respond with image tags (JSON)
chooser.py->>chooser.py: Update output["remote"] with received tags
Class diagram for removal of TagFetcher and TagMetadataclassDiagram
class TagFetcher {
- index_url: str
- docker_url: str
- last_token: str
+ fetch_sha(metadata: TagMetadata): str
+ fetch_remote_tags(repository: str, local_images: List[str]): Tuple[str, List[TagMetadata]]
}
class TagMetadata {
+ repository: str
+ image: str
+ tag: str
+ last_modified: str
+ sha: Optional[str]
+ digest: str
}
%% Both TagFetcher and TagMetadata have been removed from the codebase
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
e750324
to
a1d4579
Compare
a1d4579
to
6d08b04
Compare
6d08b04
to
bd635df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Use our own index-proxy endpoint to retrieve image tags and eliminate the custom DockerHub fetching logic.
Enhancements:
Chores: