Skip to content

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Aug 18, 2025

Summary by Sourcery

Enhancements:

  • Add asynchronous checkModelOverrides call on component mount to populate model_override_path before annotation overrides are applied

Copy link

sourcery-ai bot commented Aug 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR enhances the GenericViewer component by calling checkModelOverrides in the mounted hook to set model_override_path before loading annotation overrides.

Sequence diagram for GenericViewer mount process with model override check

sequenceDiagram
participant GenericViewer
participant checkModelOverrides
participant loadAnnotationsOverride
GenericViewer->>checkModelOverrides: call checkModelOverrides()
checkModelOverrides-->>GenericViewer: return model_override_path
GenericViewer->>loadAnnotationsOverride: call loadAnnotationsOverride()
loadAnnotationsOverride-->>GenericViewer: return override_annotations
GenericViewer->>GenericViewer: reloadAnnotations()
Loading

File-Level Changes

Change Details Files
Initialize model_override_path during component mounting
  • Invoke checkModelOverrides in the mounted hook
  • Await the result and assign it to model_override_path before loading annotation overrides
core/frontend/src/components/vehiclesetup/viewers/GenericViewer.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ES-Alexander ES-Alexander marked this pull request as ready for review August 18, 2025 16:14
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with both individual models and ALL.glb support - worked well for both! :-)

Doesn't seem to work yet for the board orientation pane in the frame selector, but that's not the fault of this PR.

The frame selector also seems to load the custom frame model for all the frames (even when not configured for all):
Screenshot 2025-08-19 at 1 08 36 am

@Williangalvani Williangalvani merged commit cb11044 into bluerobotics:master Aug 18, 2025
6 checks passed
@Williangalvani Williangalvani deleted the fix_model_overrides_maybe branch August 18, 2025 23:34
@patrickelectric
Copy link
Member

should this be on 1.4.3 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants