-
Notifications
You must be signed in to change notification settings - Fork 112
frontend: GenericViewer: checkOverrides when mounting #3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: GenericViewer: checkOverrides when mounting #3497
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR enhances the GenericViewer component by calling checkModelOverrides in the mounted hook to set model_override_path before loading annotation overrides. Sequence diagram for GenericViewer mount process with model override checksequenceDiagram
participant GenericViewer
participant checkModelOverrides
participant loadAnnotationsOverride
GenericViewer->>checkModelOverrides: call checkModelOverrides()
checkModelOverrides-->>GenericViewer: return model_override_path
GenericViewer->>loadAnnotationsOverride: call loadAnnotationsOverride()
loadAnnotationsOverride-->>GenericViewer: return override_annotations
GenericViewer->>GenericViewer: reloadAnnotations()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with both individual models and ALL.glb support - worked well for both! :-)
Doesn't seem to work yet for the board orientation pane in the frame selector, but that's not the fault of this PR.
The frame selector also seems to load the custom frame model for all the frames (even when not configured for all):
should this be on 1.4.3 ? |
Summary by Sourcery
Enhancements: