Skip to content

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Aug 14, 2025

fix #1600

Summary by Sourcery

Enhancements:

  • Raise the memory allocation for the version chooser in start-blueos-core

Copy link

sourcery-ai bot commented Aug 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR raises the memory limit for the version chooser in the start-blueos-core script by adjusting both its Java heap settings and shell resource limits, and exposes a configurable environment variable for future tweaks.

File-Level Changes

Change Details Files
Increased memory allocation for version chooser
  • Updated Java heap size (-Xmx) from 512m to 2048m
  • Raised virtual memory ulimit (ulimit ‑v) to match new heap setting
  • Added CHOOSER_MEM environment variable for configurable memory limits
core/start-blueos-core

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for it ? Can you put in the commit ?

This allows blueos to properly uncompress and load side-loaded blueos images
@Williangalvani Williangalvani force-pushed the no_version_chooser_memory_cap branch from 95a6262 to 69408a7 Compare August 15, 2025 15:59
@Williangalvani
Copy link
Member Author

is there a reason for it ? Can you put in the commit ?

updated.

The memory limit is killing version-chooser as it tries to load user-provided tar images

@Williangalvani Williangalvani marked this pull request as ready for review September 15, 2025 14:43
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

@patrickelectric patrickelectric merged commit 1f33961 into bluerobotics:master Sep 15, 2025
7 checks passed
@patrickelectric patrickelectric added the move-to-stable Needs to be cherry-picked and move to stable label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

move-to-stable Needs to be cherry-picked and move to stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version chooser gets killed by the oom-killer while doing a manual upload

2 participants