Skip to content

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Jun 19, 2025

before:

image

after:

image

Summary by Sourcery

Fix the architecture list color by removing the outdated dynamic styling and default CSS color declarations

Bug Fixes:

  • Remove the architecture_list_style computed property and its style binding from StoreExtensionCard.vue
  • Remove the hardcoded color: white rule from the .architectures-list CSS to allow correct text coloring

Copy link

sourcery-ai bot commented Jun 19, 2025

Reviewer's Guide

This PR removes the dynamic inline styling for the architecture list and cleans up the component's CSS by deleting the computed style property and the hardcoded white color rule to fix the list color.

Class diagram for StoreExtensionCard component after style cleanup

classDiagram
    class StoreExtensionCard {
        +String compatible_architectures
        +String extension_company()
        +String update_button_text()
        -architecture_list_style()  // removed
    }
Loading

File-Level Changes

Change Details Files
Removed dynamic inline styling and its computed property for the architectures list
  • Deleted :style binding from the architectures-list div
  • Removed the architecture_list_style computed property and its logic
core/frontend/src/components/kraken/cards/StoreExtensionCard.vue
Cleaned up .architectures-list CSS by removing hardcoded color
  • Deleted color: white; rule from the CSS class
  • Rely on inherited or theme-driven text color for the list
core/frontend/src/components/kraken/cards/StoreExtensionCard.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patrickelectric - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@joaomariolago
Copy link
Collaborator

We have another problem that the extension page is not being able to fetch the logos colors, that is why the texts started to mix with the tag color, so I think we need to first fix the other problem and check if this still happens.

@joaomariolago
Copy link
Collaborator

I think that a good fix will be instead of hard coding it to work with light theme just modify to fallback, since will keep both existing behavior and provide a fallback in case image do not load, also the other changes on code will not be needed.

architecture_list_style(): Record<string, string> {
  if (this.card_dominant_color === undefined) {
    return {
      color: this.$vuetify.theme.dark ? 'white' : 'black',
    }
  }

  return {
    color: this.is_card_dominant_color_light ? 'black' : 'white',
    backgroundColor: this.card_dominant_color,
  }
},

…_color is undefined

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Co-authored-by: Joao Mario Lago <joao.mario.lago@hotmail.com>
@patrickelectric
Copy link
Member Author

@joaomariolago check now

@patrickelectric patrickelectric merged commit 72567a0 into bluerobotics:master Aug 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants