Skip to content

Remove debug from 'promise-mem' #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged

Conversation

gndelia
Copy link
Contributor

@gndelia gndelia commented May 6, 2025

debug (and its dependency, ms) take up to 90% of the bundle of the promise-mem package. However,

image

  • The debug info does not really offer too much insight (the key is not even logged)
  • The code's been stable for long, so it's rare that we need to debug it
  • Ideally, we want to avoid pushing debug in prod.

After discussing with @gabmontes we decided to remove this dependency.

Process checklist

  • Manual tests passed or not applicable.
  • Automated tests added or not applicable.
  • Documentation updated or not required.

Metrics

Actual effort: 0.5h

@gndelia gndelia requested a review from gabmontes as a code owner May 6, 2025 15:25
@gndelia gndelia self-assigned this May 6, 2025
@gndelia gndelia enabled auto-merge May 6, 2025 15:26
@gndelia gndelia changed the title Promise mem remove debug Remove debug from 'promise-mem' May 6, 2025
@gndelia gndelia disabled auto-merge May 6, 2025 15:26
@gndelia gndelia enabled auto-merge May 6, 2025 15:26
@gndelia gndelia requested a review from gabmontes May 6, 2025 16:42
@gndelia gndelia merged commit 402a383 into master May 7, 2025
8 of 12 checks passed
@gndelia gndelia deleted the promise-mem-remove-debug branch May 7, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants