Skip to content

Joey bertschler #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 72 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,16 @@
* EXAMPLE
* trimProperties({ name: ' jane ' }) // returns a new object { name: 'jane' }
*/
function trimProperties(obj) {
function trimProperties(obj) { //now an argument is passed through our function
// ✨ implement
const result = {}
for (let prop in obj) {
result[prop] = obj[prop].trim()
}
return result
}


/**
* [Exercise 2] trimPropertiesMutation trims in place the properties of an object
* @param {object} obj - an object with properties that are strings
Expand All @@ -20,6 +26,10 @@ function trimProperties(obj) {
*/
function trimPropertiesMutation(obj) {
// ✨ implement
for (let prop in obj) {
obj[prop] = obj[prop].trim()
}
return obj
}

/**
Expand All @@ -32,6 +42,13 @@ function trimPropertiesMutation(obj) {
*/
function findLargestInteger(integers) {
// ✨ implement
let result = integers[0].integer //provisional variable, will overwrite result
for (let idx = 0; idx < integers.length; idx++) {
if (integers[idx].integer > result) {
result = integers[idx].integer
}
}
return result
}

class Counter {
Expand All @@ -41,6 +58,7 @@ class Counter {
*/
constructor(initialNumber) {
// ✨ initialize whatever properties are needed
this.count = initialNumber
}

/**
Expand All @@ -57,6 +75,11 @@ class Counter {
*/
countDown() {
// ✨ implement
return this.count > 0 ? this.count -- : 0
// if (this.count > 0) {
// return this.count--
// }
// return this.count
}
}

Expand All @@ -66,6 +89,8 @@ class Seasons {
*/
constructor() {
// ✨ initialize whatever properties are needed
this.seasons = ['summer', 'fall', 'winter', 'spring']
this.currentSeason = 0
}

/**
Expand All @@ -82,6 +107,13 @@ class Seasons {
*/
next() {
// ✨ implement
const result = this.seasons[this.currentSeason]
if (this.currentSeason === 3) {
this.currentSeason = 0
} else {
this.currentSeason++
}
return result
}
}

Expand All @@ -96,6 +128,8 @@ class Car {
this.odometer = 0 // car initilizes with zero miles
this.tank = tankSize // car initiazes full of gas
// ✨ initialize whatever other properties are needed
this.tankSize = tankSize
this.mpg = mpg
}

/**
Expand All @@ -113,6 +147,15 @@ class Car {
*/
drive(distance) {
// ✨ implement
const milesCanDrive = this.tank * this.mpg
if (distance <= milesCanDrive) {
this.odometer = this.odometer + distance
this.tank = this.tank - (distance / this.mpg)
} else {
this.tank = 0
this.odometer = this.odometer + milesCanDrive
}
return this.odometer
}

/**
Expand All @@ -128,6 +171,12 @@ class Car {
*/
refuel(gallons) {
// ✨ implement
const gallonsThatFit = this.tankSize - this.tank
if (gallons <= gallonsThatFit) {
this.tank = this.tank + gallons
} else {
this.tank = this.tankSize
} return this.tank * this.mpg
}
}

Expand All @@ -144,10 +193,30 @@ class Car {
* // result is false
* })
*/
function isEvenNumberAsync(number) {
// ✨ implement

// function isEvenNumberAsync(number) {
// // ✨ implement
// if (number % 2 === 0) {
// return Promise.resolve(true)
// } //no else needed bec. return above short circuits it
// return Promise.resolve(false)
// }

async function isEvenNumberAsync(number) {
if (number % 2 === 0) {
return true
}
return false
}

// async function isEvenNumberAsync(number) {
// if (typeof number !== 'number' || isNaN(number)) {
// throw new Error('number must be a number')
// }
// number % 2 === 0 || false
// }


module.exports = {
trimProperties,
trimPropertiesMutation,
Expand Down
145 changes: 124 additions & 21 deletions index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,58 +3,161 @@ const utils = require('./index')
describe('[Exercise 1] trimProperties', () => {
test('[1] returns an object with the properties trimmed', () => {
// EXAMPLE
const input = { foo: ' foo ', bar: 'bar ', baz: ' baz' }
const input = {foo: ' foo ', bar: 'bar ', baz: ' baz' }
const expected = { foo: 'foo', bar: 'bar', baz: 'baz' }
const actual = utils.trimProperties(input)
expect(actual).toEqual(expected)
})
// test('[2] returns a copy, leaving the original object intact', () => {})
test('[2] returns a copy, leaving the original object intact', () => {
const input = {foo: ' foo ', bar: 'bar ', baz: ' baz'}
utils.trimProperties(input)
expect(input).toEqual({foo: ' foo ', bar: 'bar ', baz: ' baz'})
})
})

describe('[Exercise 2] trimPropertiesMutation', () => {
// test('[3] returns an object with the properties trimmed', () => {})
// test('[4] the object returned is the exact same one we passed in', () => {})
test('[3] returns an object with the properties trimmed', () => {
const input = {foo: ' foo ', bar: 'bar ', baz: ' baz' }
const expected = { foo: 'foo', bar: 'bar', baz: 'baz' }
const actual = utils.trimProperties(input)
expect(actual).toEqual(expected)
})
test('[4] the object returned is the exact same one we passed in', () => {
const input = {foo: ' foo ', bar: 'bar ', baz: ' baz' }
const actual = utils.trimPropertiesMutation(input)
expect(actual).toBe(input)
})
})

describe('[Exercise 3] findLargestInteger', () => {
// test('[5] returns the largest number in an array of objects { integer: 2 }', () => {})
test('[5] returns the largest number in an array of objects { integer: 2 }', () => {
const input = [{ integer: 1 }, { integer: 3 }, { integer: 2 }]
const actual = utils.findLargestInteger(input)
expect(actual).toBe(3)
})
})

describe('[Exercise 4] Counter', () => {
let counter
beforeEach(() => {
counter = new utils.Counter(3) // each test must start with a fresh couter
counter = new utils.Counter(3) // each test must start with a fresh counter
})
test('[6] the FIRST CALL of counter.countDown returns the initial count', () => {
expect(counter.countDown() ).toBe(3)
})
test('[7] the SECOND CALL of counter.countDown returns the initial count minus one', () => {
counter.countDown()
expect(counter.countDown() ).toBe(2)
})
test('[8] the count eventually reaches zero but does not go below zero', () => {
counter.countDown()
counter.countDown()
counter.countDown()
counter.countDown()
expect(counter.countDown() ).toBe(0)
})
// test('[6] the FIRST CALL of counter.countDown returns the initial count', () => {})
// test('[7] the SECOND CALL of counter.countDown returns the initial count minus one', () => {})
// test('[8] the count eventually reaches zero but does not go below zero', () => {})
})

describe('[Exercise 5] Seasons', () => {
let seasons
beforeEach(() => {
seasons = new utils.Seasons() // each test must start with fresh seasons
})
// test('[9] the FIRST call of seasons.next returns "summer"', () => {})
// test('[10] the SECOND call of seasons.next returns "fall"', () => {})
// test('[11] the THIRD call of seasons.next returns "winter"', () => {})
// test('[12] the FOURTH call of seasons.next returns "spring"', () => {})
// test('[13] the FIFTH call of seasons.next returns again "summer"', () => {})
// test('[14] the 40th call of seasons.next returns "spring"', () => {})
test('[9] the FIRST call of seasons.next returns "summer"', () => {
expect(seasons.next()).toBe('summer')
})
test('[10] the SECOND call of seasons.next returns "fall"', () => {
seasons.next()
expect(seasons.next()).toBe('fall')
})
test('[11] the THIRD call of seasons.next returns "winter"', () => {
seasons.next()
seasons.next()
expect(seasons.next()).toBe('winter')
})
test('[12] the FOURTH call of seasons.next returns "spring"', () => {
seasons.next()
seasons.next()
seasons.next()
expect(seasons.next()).toBe('spring')
})
test('[13] the FIFTH call of seasons.next returns again "summer"', () => {
seasons.next()
seasons.next()
seasons.next()
seasons.next()
expect(seasons.next()).toBe('summer')
})
test('[14] the 40th call of seasons.next returns "spring"', () => {
for (let i = 0; i < 39; i++) {
seasons.next()
}
expect(seasons.next()).toBe('spring')
})
})

describe('[Exercise 6] Car', () => {
let focus
beforeEach(() => {
focus = new utils.Car('focus', 20, 30) // each test must start with a fresh car
})
// test('[15] driving the car returns the updated odometer', () => {})
// test('[16] driving the car uses gas', () => {})
// test('[17] refueling allows to keep driving', () => {})
// test('[18] adding fuel to a full tank has no effect', () => {})
test('[15] driving the car returns the updated odometer', () => {
expect(focus.drive(100)).toBe(100)
expect(focus.drive(100)).toBe(200)
expect(focus.drive(100)).toBe(300)
expect(focus.drive(200)).toBe(500)
//expect(focus.drive(200)).toBe(600)

})
test('[16] driving the car uses gas', () => {
focus.drive(600)
expect(focus.drive(1)).toBe(600)
expect(focus.drive(1)).toBe(600)
expect(focus.tank).toBe(0)

})
test('[17] refueling allows to keep driving', () => {
focus.drive(600)
focus.refuel(10)
focus.drive(600)
expect(focus.odometer).toBe(900)
focus.refuel(20)
focus.drive(600)
expect(focus.odometer).toBe(1500)
})
test('[18] adding fuel to a full tank has no effect', () => {
focus.refuel(2000000)
focus.drive(10000)
expect(focus.odometer).toBe(600)
})
})

describe('[Exercise 7] isEvenNumberAsync', () => {
// test('[19] resolves true if passed an even number', () => {})
// test('[20] resolves false if passed an odd number', () => {})
test('[19] resolves true if passed an even number', async () => {
const result = await utils.isEvenNumberAsync(2)
expect(result).toBe(true)

})
test('[20] resolves false if passed an odd number', async () => {
const result = await utils.isEvenNumberAsync(3)
expect(result).toBe(false)
})

// bonus
test('[21] rejects an error with the msg "number must be a number" if not num', async () => {
try {
await utils.isEvenNumberAsync('foo')
} catch (error) {
expect(error.message).toMatch(/number must be a number/i)
}
})

test('[22] rejects an erroror with the msg "number must be a number" if NaN', async () => {
try {
await utils.isEvenNumberAsync(NaN)
} catch (error) {
expect(error.message).toMatch(/number must be a number/i)
}
})

})
Loading