Skip to content

Exclude source code from wheel #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

subbrammanian
Copy link
Contributor

Resolves #231

Describe your changes
Remove source files (cython/cpp) from the wheel

Testing performed
Manually tested the contents of the wheel and sdist before and after to ensure only the _pystack folder with the source files have been excluded from the wheel

((venv) ) root@codespaces-bfa09f:/workspaces/pystack# diff wheelnew wheelold
4a5
> pystack/_pystack.pyx
13a15,65
> pystack/_pystack/CMakeLists.txt
> pystack/_pystack/__init__.pxd
> pystack/_pystack/compat.h
> pystack/_pystack/corefile.cpp
> pystack/_pystack/corefile.h
> pystack/_pystack/corefile.pxd
> pystack/_pystack/elf_common.cpp
> pystack/_pystack/elf_common.h
> pystack/_pystack/elf_common.pxd
> pystack/_pystack/logging.cpp
> pystack/_pystack/logging.h
> pystack/_pystack/logging.pxd
> pystack/_pystack/mem.cpp
> pystack/_pystack/mem.h
> pystack/_pystack/mem.pxd
> pystack/_pystack/native_frame.h
> pystack/_pystack/native_frame.pxd
> pystack/_pystack/process.cpp
> pystack/_pystack/process.h
> pystack/_pystack/process.pxd
> pystack/_pystack/pycode.cpp
> pystack/_pystack/pycode.h
> pystack/_pystack/pycode.pxd
> pystack/_pystack/pycompat.h
> pystack/_pystack/pyframe.cpp
> pystack/_pystack/pyframe.h
> pystack/_pystack/pyframe.pxd
> pystack/_pystack/pythread.cpp
> pystack/_pystack/pythread.h
> pystack/_pystack/pythread.pxd
> pystack/_pystack/pytypes.cpp
> pystack/_pystack/pytypes.h
> pystack/_pystack/structure.h
> pystack/_pystack/unwinder.cpp
> pystack/_pystack/unwinder.h
> pystack/_pystack/version.cpp
> pystack/_pystack/version.h
> pystack/_pystack/cpython/code.h
> pystack/_pystack/cpython/dict.h
> pystack/_pystack/cpython/float.h
> pystack/_pystack/cpython/frame.h
> pystack/_pystack/cpython/gc.h
> pystack/_pystack/cpython/int.h
> pystack/_pystack/cpython/interpreter.h
> pystack/_pystack/cpython/list.h
> pystack/_pystack/cpython/object.h
> pystack/_pystack/cpython/pthread.h
> pystack/_pystack/cpython/runtime.h
> pystack/_pystack/cpython/string.h
> pystack/_pystack/cpython/thread.h
> pystack/_pystack/cpython/tuple.h

Additional context
N/A

Signed-off-by: Subbrammanian Nochur Ganeswaran <subbrammanian@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.66%. Comparing base (3c4fd6f) to head (c639f85).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files          46       46           
  Lines        6249     6249           
  Branches      458      458           
=======================================
  Hits         5166     5166           
  Misses       1083     1083           
Flag Coverage Δ
cpp 82.66% <ø> (ø)
python_and_cython 82.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution, @subbrammanian!

@godlygeek godlygeek merged commit a402262 into bloomberg:main May 21, 2025
21 checks passed
@godlygeek
Copy link
Contributor

@subbrammanian would you be interested in contributing the same fix to Memray?

@subbrammanian
Copy link
Contributor Author

@subbrammanian would you be interested in contributing the same fix to Memray?

Yes, I'll do that sometime this week!

@subbrammanian subbrammanian deleted the exclude_cython_source_files_from_whl branch May 21, 2025 20:42
@godlygeek
Copy link
Contributor

@abstractedfox just mentioned that she's interested in contributing that fix, so she might beat you to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pystack's wheels contain the ./pystack/_pystack/ directory
3 participants