OTWO-6189 Made Branch Mandatory

Author: rapbhan

lib/ohloh_scm/git/validation.rb

@@ -3,11 +3,6 @@
 module OhlohScm
   module Git
     class Validation < OhlohScm::Validation
-      def validate
-        super
-        @errors << [:branch_name, 'Invalid Branch Name.'] if scm.branch_name.to_s.empty?
-      end
-
       private
 
       def validate_server_connection

lib/ohloh_scm/validation.rb

@@ -26,7 +26,7 @@ def validate_server_connection; end
     def validate_attributes
       @errors = []
       @errors << url_errors
-      @errors << branch_name_errors unless scm.branch_name.to_s.empty?
+      @errors << branch_name_errors
       @errors << username_errors if scm.username
       @errors << password_errors if scm.password
       @errors.compact!
@@ -48,7 +48,9 @@ def url_errors
     # rubocop:enable Metrics/AbcSize
 
     def branch_name_errors
-      if scm.branch_name.length > 80
+      if scm.branch_name.to_s.empty?
+        [:branch_name, 'Invalid Branch Name.']
+      elsif scm.branch_name.length > 80
         [:branch_name, 'The branch name must not be longer than 80 characters.']
       elsif !scm.branch_name.match?(/^[\w^\-\+\.\/\ ]+$/)
         [:branch_name, "The branch name may contain only letters, numbers, \

lib/ohloh_scm/version.rb

@@ -2,7 +2,7 @@
 
 module OhlohScm
   module Version
-    STRING = '3.0.10'
+    STRING = '3.0.11'
     GIT = '2.17.1'
     SVN = '1.9.7'
     CVSNT = '2.5.04'