Merge pull request #123 from blackducksoftware/OTWO-6189

OTWO-6189 Made Branch Mandatory for Git SCM

Author: rapbhan

lib/ohloh_scm/git/validation.rb

@@ -3,10 +3,16 @@
 module OhlohScm
   module Git
     class Validation < OhlohScm::Validation
+      def validate
+        super
+        @errors << [:branch_name, 'Invalid Branch Name.'] if scm.branch_name.to_s.empty?
+      end
+
       private
 
       def validate_server_connection
-        msg = "The server did not respond to the 'git-ls-remote' command. Is the URL correct?"
+        msg = "The server did not respond to the 'git-ls-remote' command."
+        msg << ' Are the URL and Branch fields correct?'
         @errors << [:failed, msg] unless status.exist?
       end
 

lib/ohloh_scm/version.rb

@@ -2,7 +2,7 @@
 
 module OhlohScm
   module Version
-    STRING = '3.0.9'
+    STRING = '3.0.10'
     GIT = '2.17.1'
     SVN = '1.9.7'
     CVSNT = '2.5.04'

spec/ohloh_scm/git/validation_spec.rb

@@ -7,6 +7,10 @@
     core.errors.must_be :empty?
   end
 
+  it 'must have errors for no branch_name' do
+    get_core(:git, branch_name: '').validation.send(:branch_name_errors).wont_be :empty?
+  end
+
   it 'must have errors for invalid branch_name' do
     get_core(:git, branch_name: 'x' * 81).validation.send(:branch_name_errors).wont_be :empty?
     get_core(:git, branch_name: 'foo@bar').validation.send(:branch_name_errors).wont_be :empty?