Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Sep 15, 2025

This PR contains the following updates:

Package Type Update Change
actions/setup-dotnet action major v4.3.1 -> v5.0.0

Release Notes

actions/setup-dotnet (actions/setup-dotnet)

v5.0.0

Compare Source

What's Changed
Breaking Changes

Make sure your runner is updated to this version or newer to use this release. v2.327.1 Release Notes

Dependency Updates
Bug Fixes
New Contributors

Full Changelog: actions/setup-dotnet@v4...v5.0.0


Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner September 15, 2025 02:54
@renovate renovate bot requested a review from AmyLGalles September 15, 2025 02:54
@bitwarden-bot bitwarden-bot changed the title [deps]: Update actions/setup-dotnet action to v5 [PM-25768] [deps]: Update actions/setup-dotnet action to v5 Sep 15, 2025
@bitwarden-bot
Copy link

Internal tracking:

@renovate renovate bot changed the title [PM-25768] [deps]: Update actions/setup-dotnet action to v5 [deps]: Update actions/setup-dotnet action to v5 Sep 15, 2025
@renovate renovate bot force-pushed the renovate/actions-setup-dotnet-5.x branch from bd5e392 to b9361ca Compare September 25, 2025 17:39
@renovate renovate bot requested a review from a team as a code owner September 25, 2025 17:39
@renovate renovate bot force-pushed the renovate/actions-setup-dotnet-5.x branch from b9361ca to ecb1072 Compare October 9, 2025 11:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Logo
Checkmarx One – Scan Summary & Detailsfcb2d6cb-f1b4-4816-97a8-1ab92eb55fe8

Great job! No new security vulnerabilities introduced in this pull request

@renovate renovate bot force-pushed the renovate/actions-setup-dotnet-5.x branch from ecb1072 to 67d9b6d Compare October 13, 2025 15:46
Copy link
Contributor

@AmyLGalles AmyLGalles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renovate
Copy link
Contributor Author

renovate bot commented Oct 23, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@claude
Copy link

claude bot commented Oct 23, 2025

Claude finished @renovate[bot]'s task —— View job


Review of PR #442: Update actions/setup-dotnet to v5

Summary of Changes

This PR updates actions/setup-dotnet from v4.3.1 to v5.0.0 across 3 workflow files:

  • .github/templates/workflow-templates/example-references/_build.yml
  • .github/templates/workflow-templates/example-references/_test.yml
  • .github/workflows/_sonar.yml

All updates correctly pin to commit hash d4c94342e560b34958eacfc5d055d21461ed1c5d with version comment # v5.0.0.


Critical Issues

None identified. The changes are clean and properly implemented.


Suggested Improvements

1. Runner Version Compatibility Check

Severity: Medium

The v5.0.0 release notes state:

Make sure your runner is updated to this version or newer to use this release. v2.327.1 Release Notes

Recommendation: Verify that all GitHub Actions runners used by Bitwarden (including self-hosted runners, if any) are running version v2.327.1 or newer. The workflows currently specify:

  • ubuntu-22.04 in _build.yml and _test.yml
  • ubuntu-24.04 in _sonar.yml

GitHub-hosted runners should be up-to-date, but if you use self-hosted runners for .NET builds, confirm they meet this requirement.

2. Test Coverage

Severity: Low

While this is a straightforward dependency update, consider:

  • Running test workflows that use these templates to ensure v5 compatibility
  • Verifying that the Node.js 24 upgrade doesn't introduce any behavioral changes in your .NET setup processes

Good Practices Observed

  • ✅ Actions properly pinned to commit hash with version comment
  • ✅ Consistent updates across all files
  • ✅ Follows Bitwarden workflow linter rules (step_pinned.py)
  • ✅ All three instances of the action updated (complete coverage)

Breaking Changes Impact Assessment

The v5.0.0 release includes these breaking changes:

  1. Node.js 24 upgrade: Should be transparent to end users since it's internal to the action
  2. Modernized async usage: Internal refactoring, no API changes
  3. Removed support for older .NET versions: Review if any projects rely on older .NET SDK versions that may no longer be supported

Risk Level: Low - These are primarily internal improvements with minimal risk to existing workflows.


Action Items

  • Confirm runner compatibility: Verify all runners (especially any self-hosted) are v2.327.1+
  • Test workflows: Run test workflows using these templates to validate v5 compatibility
  • Review .NET versions: Ensure projects don't rely on older .NET versions removed in setup-dotnet v5

Conclusion

This is a well-executed dependency update that follows all security best practices and repository guidelines. The changes are minimal, properly pinned, and comprehensive. The main consideration is ensuring runner compatibility as noted in the v5 release notes.

Recommendation: Approve and merge after confirming runner versions.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants