Skip to content

Conversation

@justindbaur
Copy link
Member

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

Adds a base script for creating a backport or cherry-pick style PR to another branch. This is just a base command and repos will need to make a yaml file to trigger on comments in their repo and they can customize what the PR should look like for their repo. Bitwarden collaborators will be able to write a comment like /backport to hotfix-rc on a PR and this will create a PR with all the changes applied pointing at hotfix-rc.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@github-actions
Copy link

github-actions bot commented Sep 7, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 2920880f-57b7-4edc-9c26-02bb59b8b399

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants