-
Notifications
You must be signed in to change notification settings - Fork 131
Fixing Build status for step bundles #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lpusok
wants to merge
8
commits into
master
Choose a base branch
from
SSW-2304-build-status
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
reviewed
May 12, 2025
cli/run_util.go
Outdated
|
||
// ------------------------------------------ | ||
// Main - Preparing & running the steps | ||
for idx, stepPlan := range plan.Steps { | ||
log.Printf("Step %d: %s)", idx, stepPlan.StepID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this log in long term?
4a91ca3
to
9519106
Compare
godrei
reviewed
May 14, 2025
@@ -166,10 +166,16 @@ func (r WorkflowRunner) activateAndRunSteps( | |||
failedStepRunResult := currentBuildRunResult.FailedSteps[0] | |||
failedStepEnvs := bitrise.FailedStepEnvs(failedStepRunResult) | |||
*environments = append(*environments, failedStepEnvs...) | |||
if currentStepBundleUUID != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add a test case for verifying the failed step env vars within a step bundle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.md
is updated with the changes (if needed)Version
Requires a PATCH version update
Context
BITRISE_BUILD_STATUS
env was not set to failing inside a Step bundle.Changes
Investigation details
Decisions