Skip to content

Issue add tags to readme #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 27, 2024
Merged

Issue add tags to readme #105

merged 5 commits into from
Dec 27, 2024

Conversation

dccakes
Copy link
Contributor

@dccakes dccakes commented Dec 23, 2024

Adds tag samples across a couple of contracts for better detail.

Signed-off-by: Diego Carvallo <dccakes@gmail.com>
Signed-off-by: Diego Carvallo <dccakes@gmail.com>
Signed-off-by: Diego Carvallo <dccakes@gmail.com>
@dccakes dccakes force-pushed the issue-add-tags-to-readme branch from a2e8669 to e6c89c7 Compare December 23, 2024 00:17
@dccakes dccakes linked an issue Dec 23, 2024 that may be closed by this pull request
@pflooky pflooky changed the base branch from main to dev December 23, 2024 04:48
@pflooky
Copy link
Contributor

pflooky commented Dec 23, 2024

Thanks for the PR @dccakes! Could you also update the description and examples for tags in the JSON schema as well?
Specifically in the file https://github.com/bitol-io/open-data-contract-standard/blob/dev/schema/odcs-json-schema-latest.json

Signed-off-by: Diego Carvallo <dccakes@gmail.com>
@dccakes
Copy link
Contributor Author

dccakes commented Dec 23, 2024

Thanks for the PR @dccakes! Could you also update the description and examples for tags in the JSON schema as well? Specifically in the file https://github.com/bitol-io/open-data-contract-standard/blob/dev/schema/odcs-json-schema-latest.json

Comment Addressed - @pflooky

@pflooky pflooky merged commit 58d932e into dev Dec 27, 2024
2 checks passed
@pflooky pflooky deleted the issue-add-tags-to-readme branch December 27, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We miss a description of tags with examples in the README
2 participants