Skip to content

feat: upgrade info types #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2025
Merged

feat: upgrade info types #246

merged 5 commits into from
Jun 12, 2025

Conversation

itsyaasir
Copy link
Contributor

Issue ticket

Issue ticket link: <>

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@itsyaasir itsyaasir self-assigned this May 27, 2025
@itsyaasir itsyaasir requested review from ufoscout and veeso May 29, 2025 14:08
ufoscout
ufoscout requested changes May 30, 2025
View reviewed changes
veeso
veeso reviewed May 30, 2025
View reviewed changes
@itsyaasir
refactor: remove Default trait from BuildData and UpgradeInfo structs…
14bbfab 
…; update EVM client to use UpgradeInfo directly
@itsyaasir itsyaasir requested review from ufoscout and veeso June 5, 2025 09:24
ufoscout
ufoscout requested changes Jun 5, 2025
View reviewed changes
@itsyaasir
refactor: update UpgradeInfo documentation and modify get_upgrade_inf…
eaec59c 
…o method to return last canister upgrade details
@itsyaasir itsyaasir requested a review from ufoscout June 10, 2025 04:11
@itsyaasir itsyaasir removed the request for review from veeso June 10, 2025 08:03
@ufoscout ufoscout merged commit 0287613 into main Jun 12, 2025
1 check passed
@ufoscout ufoscout deleted the feat/upgrade-info branch June 12, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veeso veeso veeso left review comments

@ufoscout ufoscout ufoscout approved these changes

Assignees

@itsyaasir itsyaasir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsyaasir @ufoscout @veeso