Skip to content

Add missing methods to evm client #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

Add missing methods to evm client #244

merged 3 commits into from
May 19, 2025

Conversation

ufoscout
Copy link
Contributor

Issue ticket

Issue ticket link: <>

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@ufoscout ufoscout requested review from veeso and Maximkaaa May 19, 2025 10:07
@ufoscout ufoscout merged commit c0f8ef1 into main May 19, 2025
1 check passed
@ufoscout ufoscout deleted the add_missing_evm_calls branch May 19, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maximkaaa Maximkaaa Maximkaaa approved these changes

@itsyaasir itsyaasir itsyaasir approved these changes

@veeso veeso veeso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ufoscout @Maximkaaa @itsyaasir @veeso