Skip to content

EPROD-1192 upgrade to ic-cdk 0.18 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

EPROD-1192 upgrade to ic-cdk 0.18 #241

wants to merge 6 commits into from

Conversation

veeso
Copy link
Contributor

@veeso veeso commented May 2, 2025

Issue ticket

Issue ticket link: https://infinityswap.atlassian.net/browse/EPROD-1192

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@ufoscout ufoscout marked this pull request as ready for review June 10, 2025 08:44
@ufoscout ufoscout requested a review from itsyaasir June 10, 2025 08:45
ufoscout
ufoscout reviewed Jun 10, 2025
View reviewed changes
Cargo.toml
ic-exports = { git = "https://github.com/bitfinity-network/canister-sdk", package = "ic-exports", tag = "v0.24.x" }
ic-log = { git = "https://github.com/bitfinity-network/canister-sdk", package = "ic-log", tag = "v0.24.x" }
ic-stable-structures = { git = "https://github.com/bitfinity-network/canister-sdk", package = "ic-stable-structures", tag = "v0.24.x" }
ic-canister = { git = "https://github.com/bitfinity-network/canister-sdk", package = "ic-canister", branch = "EPROD-1192-upgrade-to-ic-cdk-0-18" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ufoscout ufoscout ufoscout approved these changes

@itsyaasir itsyaasir Awaiting requested review from itsyaasir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veeso @ufoscout