Add a mechanism for "publishing" internal APIs for use across our libraries #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ur libraries. A client library loads the API class "BD_InternalAPI_Capture" and then calls "exposeAPI" on it to link up at runtime. If the class fails to load, or the requested API doesn't exist, it downgrades gracefully to a no-op rather than crashing. See InternalAPI.h for a more thorough description + example client.
|
Note: I'm not sure if the Bazel changes are the best way to do this! |
kstenerud
commented
Jun 5, 2025
bazel/bitdrift_swift_test.bzl
Outdated
| @@ -58,3 +58,46 @@ def bitdrift_mobile_objc_test(name, srcs, data = [], deps = [], tags = [], visib | |||
| tags = tags, | |||
| visibility = visibility, | |||
| ) | |||
|
|
|||
| def bitdrift_mobile_swift_objc_test(name, srcs_swift, srcs_objc, data = [], deps = [], tags = [], use_test_host = False, repository = "", visibility = []): | |||
There was a problem hiding this comment.
This is basically a copy of bitdrift_mobile_swift_test with an additional objc_library cribbed from bitdrift_mobile_objc_test in this same file.
kattrali
reviewed
Jun 6, 2025
There was a problem hiding this comment.
This makes sense overall. I think a good next step is probably to pull the branch into the RN library and try it out, to test both the ergonomics and the functionality work as expected. wdyk, @snowp? (Since I think you were looking into having internal APIs for RN?)
Another set of eyes on the build system changes also would help, maybe @Reflejo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client library loads the API class "BD_InternalAPI_Capture" and then calls "exposeAPI" on it to link up at runtime. If the class fails to load, or the requested API doesn't exist, it downgrades gracefully to a no-op rather than crashing.
See
InternalAPI.hfor a more thorough description + example client.The unit tests also include
SampleClient.[hm], which is a full example of a client library.