Skip to content

[Android] Force start to run off main thread #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FranAguilera
Copy link
Contributor

@FranAguilera FranAguilera commented May 30, 2025

  • Forces internals of Logger.start() to always happen of the main thread
  • Add temporary in memory cache for any Logger.log(*) calls that happen during Logger.start() gets initialized

Verification

Session with a simulated expensive LoggerImpl creation and logs being emitted while start is in process

@FranAguilera FranAguilera changed the title [Android] Always force start internals into dedicated thread + add in… [Android] Force start to run off main thread May 30, 2025
@FranAguilera FranAguilera marked this pull request as draft May 30, 2025 13:34
@FranAguilera FranAguilera force-pushed the franjam/move-to-background branch 5 times, most recently from 6e272b6 to 639d69b Compare June 2, 2025 09:56
@FranAguilera FranAguilera force-pushed the franjam/move-to-background branch from 639d69b to 788584f Compare June 2, 2025 09:56
@bitdriftlabs bitdriftlabs deleted a comment from github-actions bot Jun 2, 2025
@bitdriftlabs bitdriftlabs deleted a comment from github-actions bot Jun 2, 2025
@bitdriftlabs bitdriftlabs deleted a comment from github-actions bot Jun 2, 2025
Copy link

github-actions bot commented Jun 2, 2025

📦 APK Size Report

Metric Size (KB)
Baseline 3574
Current 3578
Difference 4

❌ APK size increased by 4 KB.

)
inMemoryLogger.flushToNative(loggerImpl)
loggerImpl.startLogger()
default.set(LoggerState.Started(loggerImpl))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to verify this a bit more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant