feat(jvm): add sdk version to reports #397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
force-pushed
the
dfuller/bit-5141-plumb-through-sdkversion
branch
from
b6f7d80 to
7224c06
Compare
kattrali
force-pushed
the
dfuller/bit-5141-plumb-through-sdkversion
branch
3 times, most recently
from
5931ca1 to
e6a9d3c
Compare
kattrali
commented
May 23, 2025
platform/jvm/capture/src/test/kotlin/io/bitdrift/capture/FatalIssueReporterProcessorTest.kt
Outdated
Show resolved
Hide resolved
kattrali
force-pushed
the
dfuller/bit-5141-plumb-through-sdkversion
branch
from
e6a9d3c to
6703930
Compare
| } | ||
|
|
||
| private class CoreSDKVersionProvider : ISDKVersionProvider { | ||
| override fun getSDKVersion(): String? = CaptureJniLibrary.getSdkVersion() |
FranAguilera
approved these changes
May 23, 2025
📦 APK Size Report
|
FranAguilera
requested changes
May 23, 2025
...capture/src/main/kotlin/io/bitdrift/capture/reports/processor/FatalIssueReporterProcessor.kt
Outdated
Show resolved
Hide resolved
kattrali
force-pushed
the
dfuller/bit-5141-plumb-through-sdkversion
branch
from
6703930 to
330c49d
Compare
📦 APK Size Report
|
kattrali
force-pushed
the
dfuller/bit-5141-plumb-through-sdkversion
branch
from
330c49d to
4be1909
Compare
📦 APK Size Report
|
ensures that the native capture lib is loaded, and only called at most once through lazily evaluating the sdkVersion property of the processor
kattrali
force-pushed
the
dfuller/bit-5141-plumb-through-sdkversion
branch
from
4be1909 to
15bcda4
Compare
📦 APK Size Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's already a nice test for ensuring the value set is sent (via
FatalIssueReporterStorageTest. This change propagates the value from core to reports.sample (you'd need to look at the actual crash artifact to confirm, I think)