Fix rotvec comparison to handle 180° rotation ambiguity #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
gemenerik
force-pushed
the
rik/fix-rotation-check
branch
from
805c61e to
8ab8e14
Compare
Replaced direct rotvec comparison with relative rotation check to avoid sign ambiguity in 180° rotations. Fixes unit test failures on Windows on Python 3.10–3.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced direct rotvec comparison with relative rotation check to avoid sign ambiguity in 180° rotations. Fixes unit test failures on Windows on Python 3.10–3.12.