Multipath descriptor support (BIP 389) #275
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Key Features:
Wallet::create_multipath(descriptor)
following the same pattern ascreate()
andcreate_single()
Usage Example:
Notes to the reviewers
Design Decisions:
make_multipath_descriptor_to_extract()
helper following the same pattern as existingmake_descriptor_to_extract()
functioncreate_multipath()
method returnsCreateParams
just likecreate()
andcreate_single()
, maintaining the fluent builder patternImplementation Notes:
make_multipath_descriptor_to_extract()
twice (once for receive, once for change) which is intentional and follows the established pattern of lazy evaluationChangelog notice
Added:
Wallet::create_multipath()
method for creating wallets from BIP 389 multipath descriptorsCreateParams::new_multipath()
for multipath descriptor parameter creationChecklists
All Submissions:
just p
before pushingNew Features:
Bugfixes:
Closes #11