Skip to content

ci: pin webpki-roots for MSRV compatibility #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025

Conversation

LagginTimes
Copy link
Contributor

Description

This PR pins the webpki-roots crate to version 1.0.1 to maintain compatibility with our current MSRV.

Changelog notice

  • Pin webpki-roots to 1.0.1 for MSRV compatibility.

Checklists

All Submissions:

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e1c8891

@@ -28,3 +28,4 @@ cargo update -p once_cell --precise "1.20.3"
cargo update -p base64ct --precise "1.6.0"
cargo update -p minreq --precise "2.13.2"
cargo update -p tracing-core --precise "0.1.33"
cargo update -p webpki-roots@1.0.2 --precise "1.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I wonder if there's a way to use the cargo package specification with a matching regex, in order to not need to update once another version is released. I've tried locally without success.

Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e1c8891

@evanlinjin evanlinjin merged commit d7639da into bitcoindevkit:master Jul 20, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants