-
Notifications
You must be signed in to change notification settings - Fork 56
deps: bdk_wallet 2.0.0-beta #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,9 +5,10 @@ use crate::bitcoin::{ | |
use crate::descriptor::Descriptor; | ||
use crate::error::{CreateTxError, RequestBuilderError}; | ||
|
||
use bdk_core::bitcoin::absolute::LockTime as BdkLockTime; | ||
use bdk_core::spk_client::SyncItem; | ||
use bdk_core::{BlockId as BdkBlockId, Merge}; | ||
use bdk_wallet::bitcoin::absolute::LockTime as BdkLockTime; | ||
use bdk_wallet::chain::spk_client::SyncItem; | ||
use bdk_wallet::chain::BlockId as BdkBlockId; | ||
use bdk_wallet::chain::Merge; | ||
|
||
use bdk_wallet::bitcoin::Transaction as BdkTransaction; | ||
use bdk_wallet::chain::spk_client::FullScanRequest as BdkFullScanRequest; | ||
|
@@ -81,7 +82,7 @@ impl From<BdkChainPosition<BdkConfirmationBlockTime>> for ChainPosition { | |
transitively: transitively.map(|t| Arc::new(Txid(t))), | ||
} | ||
} | ||
BdkChainPosition::Unconfirmed { last_seen } => ChainPosition::Unconfirmed { | ||
BdkChainPosition::Unconfirmed { last_seen, .. } => ChainPosition::Unconfirmed { | ||
timestamp: last_seen, | ||
}, | ||
} | ||
|
@@ -784,6 +785,7 @@ impl From<IndexerChangeSet> for bdk_wallet::chain::indexer::keychain_txout::Chan | |
} | ||
Self { | ||
last_revealed: changes, | ||
spk_cache: Default::default(), | ||
} | ||
} | ||
} | ||
|
@@ -918,6 +920,8 @@ impl From<TxGraphChangeSet> for bdk_wallet::chain::tx_graph::ChangeSet<BdkConfir | |
txouts, | ||
anchors, | ||
last_seen, | ||
first_seen: Default::default(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a comment here: Would we want to update There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea! I think we should do that. Let's do it in a separate PR? I'm thinking of this PR as a straight update of the dependency, and then doing follow up PR for something like exposing the new TxDetails, so if you want to do a follow up PR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok. Understood! 👍 |
||
last_evicted: Default::default(), | ||
} | ||
} | ||
} | ||
|
Uh oh!
There was an error while loading. Please reload this page.