Skip to content

chore(ci): remove MSRV for bdk-cli #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

chore(ci): remove MSRV for bdk-cli #211

merged 1 commit into from
Aug 25, 2025

Conversation

tvpeter
Copy link
Collaborator

@tvpeter tvpeter commented Aug 11, 2025 •
edited
Loading

This PR fixes #210

Description

  • Updates Rust Edition to 2024
  • Removes MSRV for the project
  • fixes clippy warnings

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

@coveralls
Copy link

coveralls commented Aug 11, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 17125019049

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 2.969%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers.rs 0 1 0.0%
src/main.rs 0 6 0.0%
Totals Coverage Status
Change from base Build 15731603419: 0.3%
Covered Lines: 25
Relevant Lines: 842
💛 - Coveralls

@tvpeter tvpeter requested a review from notmandatory August 11, 2025 15:45
@notmandatory
Copy link
Member

Looks good, you should also remove the "1.75" badge and MSRV section from the README.md file.

@tvpeter
Copy link
Collaborator Author

tvpeter commented Aug 11, 2025

Looks good, you should also remove the "1.75" badge and MSRV section from the README.md file.

Updated. Thank you

@tvpeter tvpeter added this to the CLI 1.1.0 milestone Aug 12, 2025
@tvpeter tvpeter self-assigned this Aug 12, 2025
@tvpeter tvpeter added the chore Non-coding related work label Aug 12, 2025
@tvpeter
ci(remove-msrv): remove msrv for the crate
126d98b 
- remove msrv
- remove pin-msrv.sh
- update cont_integration workflow
- fix clippy warnings
- update README
- update CHANGELOG
notmandatory
notmandatory approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 126d98b

Thanks for getting this in, should fix some other open PRs once they rebase on this one.

@tvpeter
Copy link
Collaborator Author

tvpeter commented Aug 25, 2025

Thanks for getting this in, should fix some other open PRs once they rebase on this one.

Yes, I will merge it so that other open PRs can be rebased.
Thank you

@tvpeter tvpeter merged commit a46aa9d into bitcoindevkit:master Aug 25, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this to Done in BDK-CLI Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@tvpeter tvpeter

Labels

chore Non-coding related work

Projects

BDK-CLI
Status: Done

Milestone

CLI 2.0.0

Development

Successfully merging this pull request may close these issues.

Upgrade or remove MSRV for bdk-cli project

3 participants

@tvpeter @coveralls @notmandatory