improv: Persister+Extensions #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…boardingViewModel, since deletion is always handled in Persister.createConnection().
reez
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some features in
Connection+Extensionsto help create, delete and load wallet connectionsNotes to the reviewers
• Changed file named from Connection+Extension to Persister+Extensions
• Created Persister.deleteConnection to keep easy delete wallet connections
• Created URL+Extensions to help manage Persister connections
• Removed
try bdkClient.deleteWallet()from createWallet in OnboardingViewModel, since deletion is always handled in Persister.createConnection()Checklists
All Submissions:
.swift-formatfile