Skip to content

fix: balance overflow #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

fix: balance overflow #301

merged 1 commit into from
Jul 17, 2025

Conversation

reez
Copy link
Collaborator

@reez reez commented Jul 11, 2025

Description

When a balance is 9,999,709,517 sats (10 digits) the format string was causing an integer overflow because %d expects a 32-bit integer but our value exceeds the maximum 32-bit integer (2,147,483,647).

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • UI changes tested on small, medium, and large devices to ensure layout consistency

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez
Copy link
Collaborator Author

reez commented Jul 11, 2025

prob need to fix this in Monday app too

@reez reez merged commit 9cd0612 into bitcoindevkit:main Jul 17, 2025
1 check passed
@reez reez deleted the balance branch July 17, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant