-
Notifications
You must be signed in to change notification settings - Fork 12
feat: added balance ₿-only format(bip177) #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
looking pretty good so far. The implementation uses "1K", "1M" notation which differs from BIP177's actual proposal. BIP177 suggests displaying sats as integers with thousand separators (e.g., "₿10,000" not "10K"). |
Nice, @reez. I was following these samples to create the 1k and 1M notation logic. ''' 0.00000100 BTC -> ₿100 I little confused, Wouldn’t we use this notation? |
ACK 6fdb931 This is perfect actually. My b, you're totally right, I was getting tripped up on I'll merge this (and any other open PRs) after I merge #302 (later this week hopefully when bdk-ffi/swift 2.0 is released). |
Awesome, @reez i'll implement it on Monday app too |
great! I'll merge that one as soon as I see it |
Description
This PR added ₿-only format on balance screen view and resolve the issue
Reference
https://bitcoin.design/guide/designing-products/units-and-symbols/#sample-mockups
Screens
Checklists
All Submissions:
.swift-format
fileNew Features:
I've added docs for the new feature