Skip to content

chore: fix little warning #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

r1b2ns
Copy link
Collaborator

@r1b2ns r1b2ns commented Apr 24, 2025

Description

The icon arrow.trianglehead.clockwise is only available on iOS 18. To maintain compatibility with the project’s iOS 17 deployment target, this PR replaces it with arrow.clockwise.

Screenshot 2025-04-24 at 15 29 24

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • UI changes tested on small, medium, and large devices to ensure layout consistency

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

…` to avoid message erro "No symbol named 'arrow.trianglehead.clockwise' found in system symbol set"
@r1b2ns r1b2ns requested a review from reez April 24, 2025 18:43
Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Thanks, I love keeping the codebase as tidy as possible so this helps

@reez reez merged commit c9a4670 into bitcoindevkit:main Apr 24, 2025
1 check passed
@r1b2ns r1b2ns deleted the chore/icon-unavailable-ios17 branch April 24, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants