fix: issue 289

[r1b2ns]

Description

Fix issue 289

Notes to the reviewers

This PR includes a small refactor that extracts the WalletSyncScriptInspector and WalletFullScanScriptInspector classes into separate files, and both have now been converted into actors.

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I have formatted my code with swift-format per .swift-format file

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• UI changes tested on small, medium, and large devices to ensure layout consistency

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[Copilot]

Pull Request Overview

This PR fixes issue 289 by refactoring the wallet sync and full scan inspectors into separate files and converting them into actors. It also removes duplicate progress update functions from several view models in favor of concise closure-based implementations.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
BDKSwiftExampleWallet/View Model/WalletViewModel.swift	Implements closure-based progress update and removes unused update functions.
BDKSwiftExampleWallet/View Model/Settings/SettingsViewModel.swift	Replaces the old updateProgressFullScan function with a closure for updating progress.
BDKSwiftExampleWallet/View Model/Activity/ActivityListViewModel.swift	Introduces a closure-based updateProgress and removes the redundant function implementation.
BDKSwiftExampleWallet/Actor/WalletSyncScriptInspector.swift	Moves sync inspector logic into an actor; note the use of a synchronous sleep call in an actor context.
BDKSwiftExampleWallet/Actor/WalletFullScanScriptInspector.swift	Moves full scan inspector logic into an actor using closure-based progress updates.

Files not reviewed (1)

• BDKSwiftExampleWallet.xcodeproj/project.pbxproj: Language not supported

[reez]

Nice! Feel free to add me as reviewer when this is ready for review (just want to make sure I don't start reviewing before you're ready)

[r1b2ns]

Hi @reez, I believe I don’t have the necessary permissions to add reviewers to PRs.

Could you please take a look at it?

[reez]

yeah my bad, take a look to see if you got an invite/access

[r1b2ns]

I received and accepted!! thk @reez

[reez]

What do you think about https://github.com/bitcoindevkit/BDKSwiftExampleWallet/pull/290/files#r2058436583 comment from Copilot?

Otherwise tested and everything works great!

[r1b2ns]

I’ll take care of it! One way to solve this is by using Task.sleep inside a Task, because we can’t make inspect function async to use Task.sleep directly.

I just tested this solution and works perfectly.
What do you think?

[reez]

I’ll take care of it! One way to solve this is by using Task.sleep inside a Task, because we can’t make inspect function async to use Task.sleep directly.

I just tested this solution and works perfectly. What do you think?

Love it, perfect solution.

And by the way the reason I had to sleep there was more of a UI/UX reason, on WalletView the visual progress of the scripts being inspected went too fast visually if people were new users, so just letting you know since its a bit unclear possibly exactly why I'm sleeping there