Skip to content

refactor: extract BalanceView to simplify WalletView and modularize b… #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025

Conversation

r1b2ns
Copy link
Collaborator

@r1b2ns r1b2ns commented Apr 22, 2025

Description

This PR simplifies WalletView by extracting the balance information into a separate BalanceView component.

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • UI changes tested on small, medium, and large devices to ensure layout consistency

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@r1b2ns r1b2ns marked this pull request as ready for review April 22, 2025 14:38
@reez
Copy link
Collaborator

reez commented Apr 22, 2025

  1. Would remove all changes in BDKSwiftExampleWallet.xcodeproj/project.pbxproj other than BalanceView.swift addition.

  2. And then in the PR template I see I have formatted my code with [swift-format](https://github.com/apple/swift-format) per .swift-format [file](https://github.com/reez/BDKSwiftExampleWallet/blob/main/.swift-format) checked but I dont see that the code was formatted (can just run swift format --in-place --recursive . locally to fix though)

Otherwise the rest is looking good when I tested it!

@r1b2ns
Copy link
Collaborator Author

r1b2ns commented Apr 22, 2025

I was thinking — if you want, I can configure XcodeGen to generate the .xcodeproj. What do you think?

@reez
Copy link
Collaborator

reez commented Apr 22, 2025

I was thinking — if you want, I can configure XcodeGen to generate the .xcodeproj. What do you think?

I think at some point we will do that, but I think we are going to wait on doing that. But its a good thought that makes sense.

@r1b2ns
Copy link
Collaborator Author

r1b2ns commented Apr 22, 2025

Awesome! I’ve made the changes to move this PR forward.

@reez reez merged commit 5a05d59 into bitcoindevkit:main Apr 22, 2025
1 check passed
@r1b2ns r1b2ns deleted the improv/simplify-balance-component branch April 22, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants